Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LA-166 ux issues when saving an integration #5555

Merged
merged 12 commits into from
Dec 4, 2024
Merged

LA-166 ux issues when saving an integration #5555

merged 12 commits into from
Dec 4, 2024

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Dec 3, 2024 •
edited
Loading

Description Of Changes

Fix unexpected re-enabling of an integration after saving. Fix validation issues with boolean field.

Code Changes

  • Remove hardcoded "enabled" value during connection patch
  • Replace text input with a select for boolean values in connection form

Steps to Confirm

  1. Go to admin, add system
  2. Add an integration of postgres type
  3. Fill required fields and save
  4. Check that the SSH required field is now a select with true/false values instead of a text input
  5. Toggle Disable Integration
  6. Now, save the form again
  7. Check that the integration is still disabled after saving

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 4:25pm

@lucanovera lucanovera changed the title LA-1166 ux issues when saving an integration LA-166 ux issues when saving an integration Dec 3, 2024
@cypress Cypress
Copy link

cypress bot commented Dec 3, 2024 •
edited
Loading

fides    Run #11259

Run Properties:  status check passed Passed #11259  •  git commit 658007fb5c ℹ️: Merge 6f3583a531919c357cdc712570c5e31f68b0ec18 into 8723d8468f9916b26a5434c4b02b...
Project fides
Branch Review refs/pull/5555/merge
Run status status check passed Passed #11259
Run duration 00m 49s
Commit git commit 658007fb5c ℹ️: Merge 6f3583a531919c357cdc712570c5e31f68b0ec18 into 8723d8468f9916b26a5434c4b02b...
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

lucanovera
lucanovera commented Dec 4, 2024
View reviewed changes
clients/admin-ui/cypress/support/stubs.ts
@@ -240,6 +240,10 @@ export const stubPlus = (available: boolean, options?: HealthCheck) => {
statusCode: 400,
body: {},
}).as("getPlusHealth");
cy.intercept("GET", "/api/v1/plus/*", {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not in plus, all plus endpoints should return 404.

gilluminate
gilluminate approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it is working well!

@lucanovera lucanovera merged commit a28ae2f into main Dec 4, 2024
12 checks passed
@lucanovera lucanovera deleted the LA-166-UX-issues-when-saving-an-integration branch December 4, 2024 16:29
@cypress Cypress
Copy link

cypress bot commented Dec 4, 2024

fides    Run #11261

Run Properties:  status check passed Passed #11261  •  git commit a28ae2f9de: LA-166 ux issues when saving an integration (#5555)
Project fides
Branch Review main
Run status status check passed Passed #11261
Run duration 00m 51s
Commit git commit a28ae2f9de: LA-166 ux issues when saving an integration (#5555)
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

andres-torres-marroquin pushed a commit that referenced this pull request Dec 11, 2024
@lucanovera @andres-torres-marroquin
LA-166 ux issues when saving an integration (#5555)
9ac2962 
Co-authored-by: Lucano Vera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucanovera @gilluminate